Add cancellation token to react to Copilot API changes #12773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
previously approved these changes
Sep 26, 2024
Contributor
|
@benmcmorran Are you not able to squash and merge? I could try switching your permissions from Write to Maintain. From what I read online, Write permissions should be able to squash and merge. |
Colengms
reviewed
Sep 26, 2024
Colengms
requested changes
Sep 26, 2024
Contributor
Colengms
left a comment
Colengms
left a comment
There was a problem hiding this comment.
(See existing comment. Waiting for clarification before approving.)
Member
Author
|
@Colengms I've changed the cancellation handling to follow the same pattern used by chat context. Let me know if you still have any concerns. |
Colengms
approved these changes
Sep 27, 2024
Member
Author
|
@sean-mcmanus I'm still not able to squash and merge. I suspect there are extra branch polices on
|
Contributor
You should have permissions now. |
sean-mcmanus
approved these changes
Sep 30, 2024
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reacts to upstream changes in the Copilot API that add a cancellation token and make it possible to unregister a provider.
FYI @sandersn