-
Notifications
You must be signed in to change notification settings - Fork 552
Closed
Labels
Milestone
Description
In order to unblock #251, we need to remove two settings:
docker.attachShellCommand.linuxContainerdocker.attachShellCommand.windowsContainer
Usage of these settings is very low. As a workaround when these are removed, the user can set anything for an attach command via command customization.
We can deprecate these for a release, and put in a release note; and then remove them.
- Note: Part of the function of
docker.attachShellCommand.linuxContaineris to pick between bash and sh, depending on what's present. With a very simpledocker execcommand ahead of time, we can determine whether to run bash or sh, and then proceed with executing it, rather than trying to deal with the shell quoting woes.
Reactions are currently unavailable