Skip to content

Resolve Docker build issue when using Git bash on Windows#1295

Merged
philliphoff merged 2 commits intomasterfrom
philliphoff-gitbash
Sep 23, 2019
Merged

Resolve Docker build issue when using Git bash on Windows#1295
philliphoff merged 2 commits intomasterfrom
philliphoff-gitbash

Conversation

@philliphoff
Copy link
Member

If Git bash is the default VS Code shell, building an image from the Dockerfile context menu could fail if the build context contains directory separators (as the Windows separator would be interpreted as an escape character by Git bash). Enclosing with quotes prevents the confusion.

Resolves #902

@philliphoff philliphoff requested a review from a team as a code owner September 20, 2019 22:12
@bwateratmsft bwateratmsft added this to the 0.9.0 milestone Sep 23, 2019
@philliphoff philliphoff merged commit 7f48794 into master Sep 23, 2019
@philliphoff philliphoff deleted the philliphoff-gitbash branch September 23, 2019 20:35
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Image uses wrong path separator when default terminal is git bash on Windows

2 participants