Skip to content

Use ctx.subscriptions to manage disposables#1326

Merged
bwateratmsft merged 2 commits intomasterfrom
bmw/disposables
Oct 8, 2019
Merged

Use ctx.subscriptions to manage disposables#1326
bwateratmsft merged 2 commits intomasterfrom
bmw/disposables

Conversation

@bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Oct 7, 2019

The whole of deactivateInternal can be refactored to be disposables pushed onto ctx.subscriptions. This is assuming that calling dispose() on the Disposable from start() is equivalent to, or at least also calls, stop().

@bwateratmsft bwateratmsft added this to the 0.9.0 milestone Oct 7, 2019
@bwateratmsft bwateratmsft requested a review from a team as a code owner October 7, 2019 19:08
@bwateratmsft bwateratmsft self-assigned this Oct 7, 2019
@bwateratmsft bwateratmsft merged commit 113b97f into master Oct 8, 2019
@bwateratmsft bwateratmsft deleted the bmw/disposables branch October 8, 2019 17:13
@bwateratmsft bwateratmsft removed their assignment Oct 8, 2019
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants