Add networks information to containers to allow grouping#1344
Merged
bwateratmsft merged 1 commit intomicrosoft:masterfrom Oct 14, 2019
stuartthomson:master
Merged
Add networks information to containers to allow grouping#1344bwateratmsft merged 1 commit intomicrosoft:masterfrom stuartthomson:master
bwateratmsft merged 1 commit intomicrosoft:masterfrom
stuartthomson:master
Conversation
bwateratmsft
approved these changes
Oct 14, 2019
Collaborator
bwateratmsft
left a comment
bwateratmsft
left a comment
There was a problem hiding this comment.
Looks good. Can you add a few screenshots? Thanks!
Contributor
Author
|
@bwateratmsft Sure, do you want me to add them to this PR or into the repo somewhere? |
Collaborator
|
@stuartthomson Just to the PR is fine |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows containers to be grouped by network in the containers view. I would personally prefer to be able see the connected containers in the networks view (see #1002), but it is not completely obvious how to handle the grouping in that scenario so I haven't done any work on that in this PR.