You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@EricJizbaMSFT I used depcheck to find these; it also had some other suggestions I knew were mistaken (e.g. dockerfile-language-server-nodejs). Nevertheless it does build with this set removed. The only one that I was less sure about was azure-arm-resource, but it builds fine without it.
@EricJizbaMSFT I used depcheck to find these; it also had some other suggestions I knew were mistaken (e.g. dockerfile-language-server-nodejs). Nevertheless it does build with this set removed. The only one that I was less sure about was azure-arm-resource, but it builds fine without it.
Incidentally, azure-arm-resource comes anyway since it's a dependency of vscode-azureappservice.
bwateratmsft
changed the title
Remove some unused dependencies
Remove some unneeded direct dependencies
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these are direct dependencies and so can be removed. All three are still dependencies of dependencies, though...