Skip to content

Remove some unneeded direct dependencies#1347

Merged
bwateratmsft merged 2 commits intomasterfrom
bmw/deps
Oct 16, 2019
Merged

Remove some unneeded direct dependencies#1347
bwateratmsft merged 2 commits intomasterfrom
bmw/deps

Conversation

@bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Oct 16, 2019

None of these are direct dependencies and so can be removed. All three are still dependencies of dependencies, though...

@bwateratmsft bwateratmsft requested a review from a team as a code owner October 16, 2019 15:34
@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Oct 16, 2019

@EricJizbaMSFT I used depcheck to find these; it also had some other suggestions I knew were mistaken (e.g. dockerfile-language-server-nodejs). Nevertheless it does build with this set removed. The only one that I was less sure about was azure-arm-resource, but it builds fine without it.

@bwateratmsft bwateratmsft added this to the 0.9.0 milestone Oct 16, 2019
@bwateratmsft
Copy link
Collaborator Author

@EricJizbaMSFT I used depcheck to find these; it also had some other suggestions I knew were mistaken (e.g. dockerfile-language-server-nodejs). Nevertheless it does build with this set removed. The only one that I was less sure about was azure-arm-resource, but it builds fine without it.

Incidentally, azure-arm-resource comes anyway since it's a dependency of vscode-azureappservice.

@bwateratmsft bwateratmsft changed the title Remove some unused dependencies Remove some unneeded direct dependencies Oct 16, 2019
Copy link
Member

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bwateratmsft bwateratmsft merged commit 2a70a2c into master Oct 16, 2019
@ejizba
Copy link
Contributor

ejizba commented Oct 16, 2019

Looks like the docker repo already has the no-implicit-dependencies tslint rule turned on and I would trust that

https://palantir.github.io/tslint/rules/no-implicit-dependencies/

https://github.com/microsoft/vscode-docker/blob/master/tslint.json#L115

@bwateratmsft bwateratmsft deleted the bmw/deps branch October 16, 2019 17:17
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants