Aggregate Docker build/run task labels with VS Code defaults#1396
Merged
philliphoff merged 2 commits intobmw/customexecutionfrom Nov 6, 2019
Merged
Aggregate Docker build/run task labels with VS Code defaults#1396philliphoff merged 2 commits intobmw/customexecutionfrom
philliphoff merged 2 commits intobmw/customexecutionfrom
Conversation
karolz-ms
approved these changes
Nov 6, 2019
bwateratmsft
approved these changes
Nov 6, 2019
bwateratmsft
added a commit
that referenced
this pull request
Nov 6, 2019
* Use CustomExecution instead of ShellExecution * Rev to 0.9.0 * Change to use child_process.spawn * Refresh dockerode before trees * Aggregate Docker build/run task labels with VS Code defaults (#1396)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the addition of the default VS Code labels to Docker images/containers to the base task providers in order to apply to all platforms (instead of just .NET Core). Also updates the logic so that default labels are included (by default) even if the user explicitly adds their own labels, with an option (by setting
docker[Build|Run].labels.includeDefaults = false) to not include the default labels.Resolves #1392 (except for discussion related to ports, which should be a separate PR).