Create a release-ish task in .NET Core apps#1418
Merged
bwateratmsft merged 1 commit intomasterfrom Nov 12, 2019
Merged
Conversation
karolz-ms
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It became necessary to add an
enableDebuggingflag like Node had. Otherwise, we map/src,/app, and others./appin particular prevents the release mode from working because we overwrite the/appfolder, containing the relevant binary directly, with the project folder on the host machine, which contains the (debug, aka wrong) binary a few folders down (bin/Debug/netcoreapp3.0or similar).The SSL-related folders still need to be mapped, along with
ASPNETCORE_ENVIRONMENT=Developmentin order to make SSL work. In a real production build, they would need to map in user secrets differently.The diff is super weird; we're just guarding several volumes inside
if (helperOptions.enableDebugging).