Change to removing images by name#1803
Merged
bwateratmsft merged 6 commits intomasterfrom Apr 1, 2020
Merged
Conversation
karolz-ms
approved these changes
Mar 31, 2020
karolz-ms
reviewed
Mar 31, 2020
bwateratmsft
commented
Mar 31, 2020
ravipal
reviewed
Mar 31, 2020
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Change to removing images by name * 409 error catching doesn't appear to be needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1529, #333 (both indirectly).
If we remove by name instead of by ID, then the 409 conflict error won't happen anymore. If there are child images, then this will simply remove the tag of the parent image; later on if the child is removed it will also remove this parent image (assuming there aren't any other tags).