Merged
Conversation
karolz-ms
suggested changes
May 13, 2020
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
karolz-ms
approved these changes
May 13, 2020
Contributor
karolz-ms
left a comment
karolz-ms
left a comment
There was a problem hiding this comment.
Looks good, thanks for addressing the feedback!
ravipal
added a commit
that referenced
this pull request
May 14, 2020
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
ravipal
added a commit
that referenced
this pull request
May 14, 2020
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1965