Skip to content

Deprecate attach command settings #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwateratmsft merged 1 commit into from
May 15, 2020
Merged

Deprecate attach command settings #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2027,12 +2027,14 @@
"docker.attachShellCommand.linuxContainer": {
"type": "string",
"default": "/bin/sh -c \"[ -e /bin/bash ] && /bin/bash || /bin/sh\"",
"description": "%vscode-docker.config.docker.attachShellCommand.linuxContainer%"
"description": "%vscode-docker.config.docker.attachShellCommand.linuxContainer%",
"deprecationMessage": "%vscode-docker.config.deprecated%"
},
"docker.attachShellCommand.windowsContainer": {
"type": "string",
"default": "cmd",
"description": "%vscode-docker.config.docker.attachShellCommand.windowsContainer%"
"description": "%vscode-docker.config.docker.attachShellCommand.windowsContainer%",
"deprecationMessage": "%vscode-docker.config.deprecated%"
},
"docker.dockerComposeBuild": {
"type": "boolean",
Expand Down
1 change: 1 addition & 0 deletions package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
"vscode-docker.config.docker.dockerComposeBuild": "Set to true to include --build option when docker-compose command is invoked",
"vscode-docker.config.docker.dockerComposeDetached": "Set to true to include --d (detached) option when docker-compose command is invoked",
"vscode-docker.config.docker.showRemoteWorkspaceWarning": "Set to true to prompt to switch from \"UI\" extension mode to \"Workspace\" extension mode if an operation is not supported in UI mode.",
"vscode-docker.config.deprecated": "This setting has been deprecated and will be removed in a future release.",
"vscode-docker.commands.api.configure": "Add Docker Files to Workspace (API)...",
"vscode-docker.commands.compose.down": "Compose Down",
"vscode-docker.commands.compose.restart": "Compose Restart",
Expand Down