Fix issues with deprecation warning#2007
Merged
bwateratmsft merged 1 commit intomasterfrom May 21, 2020
Merged
Conversation
bwateratmsft
commented
May 21, 2020
| // extension as a whole to depend on it. Hence, we only check for its existence if/when asked to | ||
| // debug .NET Core in Docker containers. | ||
| const dependenciesSatisfied = this.getExtension('ms-vscode.csharp') !== undefined; | ||
| const dependenciesSatisfied = this.getExtension('ms-vscode.csharp') !== undefined || this.getExtension('ms-dotnettools.csharp') !== undefined; |
Collaborator
Author
There was a problem hiding this comment.
The C# extension changed their publisher (and thus, extension ID) without bothering to see who was using it; I noticed today when testing the old-style debugging for .NET Core.
philliphoff
approved these changes
May 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with #1952 and also deals with the new C# extension publisher.