Add new Docker SDK-based client#2134
Conversation
| } | ||
| } | ||
| }, | ||
| "@octokit/auth-token": { |
There was a problem hiding this comment.
This octokit stuff is probably unnecessary. I have opened an issue docker/node-sdk#22
There was a problem hiding this comment.
Webpack's tree shaking is removing the Octokit stuff (as expected), so I think it's OK to merge these changes. We'll pick up a new version of the Docker SDK as soon as one is available.
|
landed here following issues from https://github.com/docker/node-sdk ; just noticed "remove" is not planned to be implemented as "not supported in sdk". |
That was a mis-type by me, Remove will be present. Just stop/start/restart are being turned off (for now). I fixed the initial comment. |
| let osType = await getDockerOSType(context); | ||
| let osType: DockerOSType; | ||
| try { | ||
| osType = await getDockerOSType(context); |
There was a problem hiding this comment.
Get OS type from container instead of system? That would allow for Windows containers in ACI to work.
*Need the SDK to provide platform
* Implement client for Docker SDK * Add another stopped container state * Assume linux if we can't tell what OS * Disable stop * Monkey patch in a label for compose proj * Add getCurrentContext method
3 participants
Fixes #2102
Add the new Docker SDK-based client under the "DockerServe" client implementation. Supported context-menu commands on containers include:
These are not* implemented in the Docker SDK yet and will show an error "This action is not supported in the current Docker context.":
*Stop is but the behavior is not exactly the same as
docker stop, due to the limitations of ACI. We'll leave it unimplemented for now.