Allow users to download container files#2551
Merged
Conversation
karolz-ms
suggested changes
Dec 9, 2020
Contributor
karolz-ms
left a comment
karolz-ms
left a comment
There was a problem hiding this comment.
Overall looks great, just minor suggestions/questions
karolz-ms
approved these changes
Dec 9, 2020
Closed
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Sketch download of container files. * Manage existing files during download. * Updates per PR feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently users can open (text) files of running containers in the VS Code editor. This change adds a new download command that, like in VS, allows the user to instead extract files from running containers and save them in a user-selected local folder. Multiple files can be downloaded at a given time. If the file already exists in the selected folder, the user will be prompted to skip that file, overwrite that file, or to cancel any remaining download.
Resolves #2466.