Use managed service identity for pulling from ACR#2796
Merged
bwateratmsft merged 4 commits intomainfrom Mar 22, 2021
Merged
Conversation
bwateratmsft
commented
Mar 18, 2021
karolz-ms
reviewed
Mar 19, 2021
Contributor
karolz-ms
left a comment
karolz-ms
left a comment
There was a problem hiding this comment.
LGTM, just assume you will attempt to grant ACR access before deploying the image, so waiting with approval to see if that is successful
bwateratmsft
commented
Mar 19, 2021
karolz-ms
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1685 so we can finally stop punting it. 😄
Still need to verify:
@azure/arm-authorizationpackage does not get loaded beforeDeploy to Azure App Serviceis calledidentityfield doesn't cause problems with deployments from other container registries (e.g. Docker Hub)