Skip to content

Add a step to open a folder at the beginning#3231

Merged
bwateratmsft merged 5 commits intomainfrom
bmw/openFolder
Oct 6, 2021
Merged

Add a step to open a folder at the beginning#3231
bwateratmsft merged 5 commits intomainfrom
bmw/openFolder

Conversation

@bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Sep 23, 2021

Fixes #3223.

image

@bwateratmsft bwateratmsft requested a review from a team as a code owner September 23, 2021 15:51
@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Sep 23, 2021

TODO: Should we change the verbiage on the "Run container" step to not refer back to previous steps that may or may not exist?

Done: #3231 (comment)

Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ucheNkadiCode
Copy link
Contributor

the verbiage on the "Run container" step t

I'm not understanding which steps WOULD NOT exist before "Run containers". Wouldn't that be to create a dockerfile?

@bwateratmsft
Copy link
Collaborator Author

@ucheNkadiCode if no workspace is open, "Add Dockerfiles" and "Build Image" will not show up because it isn't possible for them to succeed. So, that would make "Run containers" the first step, and the prose would begin with "Now that you've built an image..."

@bwateratmsft
Copy link
Collaborator Author

Screenshots for the new verbiage @ucheNkadiCode came up with:

image
image

@bwateratmsft bwateratmsft merged commit 635eb47 into main Oct 6, 2021
@bwateratmsft bwateratmsft deleted the bmw/openFolder branch October 6, 2021 12:55
@microsoft microsoft locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show an "Open Folder" step before running image, if no workspace is open

3 participants