Update Dockerfile language server to 0.10.2#3955
Merged
bwateratmsft merged 4 commits intomicrosoft:mainfrom Jun 1, 2023
Merged
Update Dockerfile language server to 0.10.2#3955bwateratmsft merged 4 commits intomicrosoft:mainfrom
bwateratmsft merged 4 commits intomicrosoft:mainfrom
Conversation
This update adds heredoc support for COPY so that it does not try to format it or lint it for Dockerfile-specific errors. The update also includes a fix caused by quotes in comments that can cause the semantic highlighter to get into an infinite loop. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
The new version includes a fix for parsing files with a UTF-8 BOM header. Signed-off-by: Remy Suen <remy.suen@gmail.com>
This newer version includes various fixes related to multiline instructions with string content and CRLF newline delimiters. Signed-off-by: Remy Suen <remy.suen@gmail.com>
bwateratmsft
approved these changes
Jun 1, 2023
This was
linked to
issues
Jun 1, 2023
Collaborator
|
Works great, thanks as always Remy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, apologies to everyone for having just disappeared into thin air and also thank you to everyone for your continued bug reports (even if I did not respond to them until now...) as it helps me identify things to fix to make everyone's Dockerfile editing experience a little better. I can't promise any turnaround times but I hope to be more responsive than I have been in the last year or so after seemingly dropping off the face of the earth. :P
This update adds heredoc support for
COPYso that it does not try to format it or lint it for Dockerfile-specific errors. The update also includes a fix caused by quotes in comments that can cause the semantic highlighter to get into an infinite loop.This should fix the following issues:
This does not fix #3576 (comment). I need to wrap my head around that one and I would suggest creating a separate issue about that.
The following file should trigger the above three problems so it can be verified on the current build. With the fix, you should:
/folderin the secondCOPYbut ignore the firstCOPY