Skip to content

Update Dockerfile language server to 0.10.2#3955

Merged
bwateratmsft merged 4 commits intomicrosoft:mainfrom
rcjsuen:dockerfile-language-server-0.10.0
Jun 1, 2023
Merged

Update Dockerfile language server to 0.10.2#3955
bwateratmsft merged 4 commits intomicrosoft:mainfrom
rcjsuen:dockerfile-language-server-0.10.0

Conversation

@rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented May 28, 2023

First of all, apologies to everyone for having just disappeared into thin air and also thank you to everyone for your continued bug reports (even if I did not respond to them until now...) as it helps me identify things to fix to make everyone's Dockerfile editing experience a little better. I can't promise any turnaround times but I hope to be more responsive than I have been in the last year or so after seemingly dropping off the face of the earth. :P


This update adds heredoc support for COPY so that it does not try to format it or lint it for Dockerfile-specific errors. The update also includes a fix caused by quotes in comments that can cause the semantic highlighter to get into an infinite loop.

This should fix the following issues:

This does not fix #3576 (comment). I need to wrap my head around that one and I would suggest creating a separate issue about that.

The following file should trigger the above three problems so it can be verified on the current build. With the fix, you should:

  1. not be spammed by the "Request textDocument/semanticTokens/full failed." error whenever you try to type anything in the file
  2. formatting should indent /folder in the second COPY but ignore the first COPY
  3. as noted in the file, line 11 should not get flagged by a false positive
FROM ubuntu 

RUN echo "hi there" &\
# Let's add a comment with a markdown link [here](https://www.google.com) hope nothing breaks...
echo "oops I broke something and I'm getting a lot of popup messages"

# there should not be an empty continuation line error on line 11
COPY <<EOF /bar/foo
a
b

c
EOF

COPY a b \
/folder/

This update adds heredoc support for COPY so that it does not try to
format it or lint it for Dockerfile-specific errors. The update also
includes a fix caused by quotes in comments that can cause the semantic
highlighter to get into an infinite loop.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen requested a review from a team as a code owner May 28, 2023 16:01
rcjsuen added 2 commits May 31, 2023 16:23
Signed-off-by: Remy Suen <remy.suen@gmail.com>
The new version includes a fix for parsing files with a UTF-8 BOM
header.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen dismissed a stale review via dcc5c5f May 31, 2023 20:25
@rcjsuen rcjsuen changed the title Update Dockerfile language server to 0.10.0 Update Dockerfile language server to 0.10.1 May 31, 2023
This newer version includes various fixes related to multiline
instructions with string content and CRLF newline delimiters.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@bwateratmsft
Copy link
Collaborator

Works great, thanks as always Remy!

@rcjsuen rcjsuen changed the title Update Dockerfile language server to 0.10.1 Update Dockerfile language server to 0.10.2 Jun 1, 2023
@rcjsuen rcjsuen deleted the dockerfile-language-server-0.10.0 branch June 1, 2023 12:57
@microsoft microsoft locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants