You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure the debugger directory exists prior to starting the container (or, rather, before any possible use of the directory), to prevent it potentially being created with permissions different than those used by VS Code (to actually acquire the debugger).
I have larger questions about the use of a fileSystemHandler - all the functionality I could see in the codebase could be done with fs-extra's functionality. I don't think that should block this PR, but I'd like some context on that soon.
I have larger questions about the use of a fileSystemHandler - all the functionality I could see in the codebase could be done with fs-extra's functionality. I don't think that should block this PR, but I'd like some context on that soon.
The FileSystemProvider serves several purposes, as a shield from the external library actually used (i.e. fs-extra) which allows it to be easily swapped with another if needed in the future, as an adaptor for when that library doesn't exactly provide the desired API (e.g. separate file/dir exist functions), as a convenient unit of dependency injection, and as a point for mocking in unit tests.
Could fs-extra have been used directly, yes. But consider the (currently) pending PR (#903) to replace opn, where a number of places in the code had to be touched due to the change. Had the openExternal() function existed as an abstraction layer for opn in the beginning, the change likely would have been much smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the debugger directory exists prior to starting the container (or, rather, before any possible use of the directory), to prevent it potentially being created with permissions different than those used by VS Code (to actually acquire the debugger).
This resolves #897.