Skip to content

Ensure all users use new discovery code regardless of their experiment settings #17563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 2 commits into from
Sep 29, 2021
+6 −5
Merged

Ensure all users use new discovery code regardless of their experiment settings #17563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10df707
Ensure all users use new discovery code regardless of their experimen…
Sep 29, 2021
f1e2160
News entry
Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/17563.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure all users use new discovery code regardless of their experiment settings.
10 changes: 5 additions & 5 deletions src/client/common/experiments/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ export class ExperimentService implements IExperimentService {
}

public inExperimentSync(experiment: string): boolean {
if (experiment === DiscoveryVariants.discoveryWithoutFileWatching) {
// Enable discovery experiment for all users.
return true;
}

if (!this.experimentationService) {
return false;
}
Expand All @@ -127,11 +132,6 @@ export class ExperimentService implements IExperimentService {
return true;
}

if (experiment === DiscoveryVariants.discoveryWithoutFileWatching) {
// Enable discovery experiment for all users.
return true;
}

// If getTreatmentVariable returns undefined,
// it means that the value for this experiment was not found on the server.
const treatmentVariable = this.experimentationService.getTreatmentVariable(EXP_CONFIG_ID, experiment);
Expand Down