Make MSYS2 git compatible (not only Git for Windows)#134146
Open
zcsizmadia wants to merge 24 commits intomicrosoft:mainfrom
Open
Make MSYS2 git compatible (not only Git for Windows)#134146zcsizmadia wants to merge 24 commits intomicrosoft:mainfrom
zcsizmadia wants to merge 24 commits intomicrosoft:mainfrom
Conversation
Author
|
Similar PR can be made to https://github.com/eamodio/vscode-gitlens to fix gitkraken/vscode-gitlens#965 |
Nirzak
previously approved these changes
Sep 29, 2021
7 tasks
|
Will it be merged and fix the problem? I using Cygwin64 git, and meet this problem "spawn C:\cygwin64\bin\git.exe ENOENT" |
|
So is there any current status on this? I see one approval, which is not enough for the Community PR Approvals workflow, and the last activity has by now been over a year ago... |
ProditorMagnus
approved these changes
May 10, 2024
ProditorMagnus
approved these changes
May 10, 2024
ProditorMagnus
approved these changes
May 17, 2024
Contributor
|
Plz approve this? Almost another year... |
|
please approve this, we realllllllllllllllllllllllly need this feature! |
|
This seems to no longer be required as of this MSYS2 PR that finally unifies the MSYS2/MINGW64 and Git-for-Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When MSYS2 git is used with Visual Code (instead of Git for Windows), the vscode built-in git extension fails to initialize:
Issue:
MSYS2 git rev-parse --show-toplevel returns cygwin style path vs Git for Windows, which returns Windows style path.
Solution:
If Cygwin style path is detected convert it to Windows style
References:
#111504
#4651
#17461