Skip to content

Make MSYS2 git compatible (not only Git for Windows)#134146

Open
zcsizmadia wants to merge 24 commits intomicrosoft:mainfrom
zcsizmadia:fix-msys2-git-rev-parse
Open

Make MSYS2 git compatible (not only Git for Windows)#134146
zcsizmadia wants to merge 24 commits intomicrosoft:mainfrom
zcsizmadia:fix-msys2-git-rev-parse

Conversation

@zcsizmadia
Copy link
Copy Markdown

@zcsizmadia zcsizmadia commented Sep 29, 2021

Problem:
When MSYS2 git is used with Visual Code (instead of Git for Windows), the vscode built-in git extension fails to initialize:

Validating found git in: C:\msys64\usr\bin\git.exe
Using git 2.33.0 from C:\msys64\usr\bin\git.exe
> git rev-parse --git-dir
Opening repository for path='c:\Project' failed; ex=spawn C:\msys64\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\msys64\usr\bin\git.exe ENOENT

Issue:
MSYS2 git rev-parse --show-toplevel returns cygwin style path vs Git for Windows, which returns Windows style path.

Solution:
If Cygwin style path is detected convert it to Windows style

References:
#111504
#4651
#17461

@zcsizmadia zcsizmadia changed the title AE-0001: Convert cygwin style path to Windows path style (returned by… Make MSYS2 git compatible (not only Git for Windows) Sep 29, 2021
@zcsizmadia
Copy link
Copy Markdown
Author

Nirzak
Nirzak previously approved these changes Sep 29, 2021
@hayden-pan
Copy link
Copy Markdown

Will it be merged and fix the problem? I using Cygwin64 git, and meet this problem "spawn C:\cygwin64\bin\git.exe ENOENT"

Copy link
Copy Markdown

@richmondb richmondb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@RivenSkaye
Copy link
Copy Markdown

So is there any current status on this? I see one approval, which is not enough for the Community PR Approvals workflow, and the last activity has by now been over a year ago...

@RichardLuo0
Copy link
Copy Markdown
Contributor

Plz approve this? Almost another year...

@steveviuv
Copy link
Copy Markdown

please approve this, we realllllllllllllllllllllllly need this feature!

@RivenSkaye
Copy link
Copy Markdown

This seems to no longer be required as of this MSYS2 PR that finally unifies the MSYS2/MINGW64 and Git-for-Windows git packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

git GIT issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.