Update Rust grammar from upstream repository#194758
Update Rust grammar from upstream repository#194758Wilfred wants to merge 1 commit intomicrosoft:mainfrom
Conversation
PR microsoft#194614 aimed to include the commit dustypomerleau/rust-syntax@328a682 but it looks like it actually took the prior commit. Update the grammar to correctly reflect the upstream repo.
|
@Wilfred thanks for the PR! That the commit and the file contents don't match indicates a bigger problem. I first suspected a problem with the tooling we use to pull in grammar updates (and there is an issue where the commit doesn't match the contents), but the bigger problem is that https://github.com/dustypomerleau/rust-syntax has both a I will update VS Code to pull from |
|
PR with the fix for VS Code is here: #194787 |
|
@alexr00 Thanks, that's super helpful. To be clear, are you periodically pulling from the upstream repo, or should I be submitting PRs here when I merge PRs on the upstream repo? |
|
I pull changes from upstream grammar repos about once per month via a script, usually at the very beginning of our development iteration. If there's a change that you think should be pulled immediately you can @ mention me and I can pick the changes up more immediately. |
PR #194614 aimed to include the commit
dustypomerleau/rust-syntax@328a682 but it looks like it actually took the prior commit.
Update the grammar to correctly reflect the upstream repo.