Add FileDecoration backgroundColor support and tree row rendering#310165
Open
egorovsa wants to merge 9 commits intomicrosoft:mainfrom
Open
Add FileDecoration backgroundColor support and tree row rendering#310165egorovsa wants to merge 9 commits intomicrosoft:mainfrom
egorovsa wants to merge 9 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @joaomorenoMatched files:
@benibenjMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR implements
backgroundColorsupport for file decorations, addressing my own feature request in #239308.This issue also related to this feature #31308.
Today
vscode.FileDecorationsupports text color (color) but not background color.This change enables extensions to highlight decorated items more clearly by applying a background color in addition to foreground color.
What
backgroundColor?: ThemeColortovscode.FileDecorationAPI surface:src/vscode-dts/vscode.d.tssrc/vscode-dts/vscode.proposed.codiconDecoration.d.tsextHostTypes,extHost.protocol,extHostDecorations,mainThreadDecorations)IDecorationData.backgroundColorIDecoration.bgColorClassNamehandling.monaco-tl-decoration-containerlayer in tree row templatepointer-events: noneto decoration layer to avoid interaction regressionsNotes
This PR is a direct implementation of the feature request opened by me in #239308.
After the merge
This feature will allow me to update my extension and provide users with the ability to colorize files like this:
