CopilotCLI: Hide plan when switching sessions#311280
Open
DonJayamanne wants to merge 1 commit intomainfrom
Open
CopilotCLI: Hide plan when switching sessions#311280DonJayamanne wants to merge 1 commit intomainfrom
DonJayamanne wants to merge 1 commit intomainfrom
Conversation
Contributor
Screenshot ChangesBase: Changed (25)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithFileChangesList/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithFileChangesList/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadge/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadge/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedRead/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedRead/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/FailedWithDuration/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/FailedWithDuration/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/FailedWithoutDuration/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/FailedWithoutDuration/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithDiffChanges/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithDiffChanges/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadgeAndDiff/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadgeAndDiff/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CloudProvider/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CloudProvider/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/BackgroundProvider/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/BackgroundProvider/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ClaudeProvider/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ClaudeProvider/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat input UI behavior so that plan review widgets are cleared when the user switches to a different chat session, preventing plan content from “leaking” across sessions in the workbench chat widget.
Changes:
- Detect session changes on
onDidChangeViewModeland clear plan review widgets when the current session doesn’t match any tracked plan review session resource. - Mirrors existing “question carousel” session-switch cleanup behavior for plan reviews.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Clears plan review UI state when switching to a different session resource, aligning behavior with question carousel cleanup. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.