style: fix button dropdown styles in chat plan review container#311341
Draft
DonJayamanne wants to merge 1 commit intomainfrom
Draft
style: fix button dropdown styles in chat plan review container#311341DonJayamanne wants to merge 1 commit intomainfrom
DonJayamanne wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes inconsistent heights between segments of monaco-button-dropdown buttons in the chat plan review UI (both the collapsed inline actions and the footer actions), aligning them with the 22px button height used elsewhere in chat widgets.
Changes:
- Set a consistent
height: 22pxon.monaco-button-dropdownin the plan review inline-actions and footer. - Adjust dropdown segment padding/box sizing and remove separator padding to keep the segments visually aligned.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css |
Normalizes dropdown button segment sizing in the plan review container (inline actions + footer). |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css:257
- This duplicates the
.monaco-button-dropdownstyling block used for the title inline-actions above. Consider grouping the selectors (inline-actions + footer) into a shared rule to reduce duplication and the risk of the two locations drifting over time.
.interactive-session .chat-plan-review-container .chat-plan-review-footer .monaco-button-dropdown {
width: auto;
height: 22px;
align-items: stretch;
}
.interactive-session .chat-plan-review-container .chat-plan-review-footer .monaco-button-dropdown > .monaco-button.monaco-dropdown-button {
padding: 0 4px;
box-sizing: border-box;
}
.interactive-session .chat-plan-review-container .chat-plan-review-footer .monaco-button-dropdown > .monaco-button-dropdown-separator {
padding: 0;
}
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
139
to
+151
| .interactive-session .chat-plan-review-container .chat-plan-review-inline-actions .monaco-button-dropdown { | ||
| width: auto; | ||
| height: 22px; | ||
| align-items: stretch; | ||
| } | ||
|
|
||
| .interactive-session .chat-plan-review-container .chat-plan-review-inline-actions .monaco-button-dropdown > .monaco-button.monaco-dropdown-button { | ||
| padding: 0 4px; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .interactive-session .chat-plan-review-container .chat-plan-review-inline-actions .monaco-button-dropdown > .monaco-button-dropdown-separator { | ||
| padding: 0; |
There was a problem hiding this comment.
The .monaco-button-dropdown rules for inline actions and footer are identical (height/align-items + dropdown-button + separator). Consider consolidating these selectors into a single rule (e.g. grouping both containers) to avoid style drift between the two locations. Also, align-items: stretch is the default for flex containers, so it can likely be omitted if not needed for an override.
This issue also appears on line 244 of the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311327