Skip to content

fix(agents): vscode app launch due to missing app identifiers#311362

Merged
deepak1556 merged 1 commit intomainfrom
roob/fix_sibling_app_spawn
Apr 20, 2026
Merged

fix(agents): vscode app launch due to missing app identifiers#311362
deepak1556 merged 1 commit intomainfrom
roob/fix_sibling_app_spawn

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 commented Apr 20, 2026 •
edited
Loading

Followup to #310773

The product.sub.json overlay in bootstrap-meta.ts uses shallow merge.
This caused the entire `embedded` object from product.json to be replaced by product.sub.json's version,
losing unique properties injected by the build such as `darwinSiblingBundleIdentifier` and `win32SiblingExeBasename`.

@deepak1556 deepak1556 added this to the 1.117.0 milestone Apr 20, 2026
@deepak1556 deepak1556 self-assigned this Apr 20, 2026
Copilot AI review requested due to automatic review settings April 20, 2026 13:18
@deepak1556 deepak1556 enabled auto-merge (squash) April 20, 2026 13:21
Copilot AI reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes embedded-agent/VS Code app launching behavior when app identifiers are missing by ensuring embedded product configuration is merged correctly during bootstrap (follow-up to #310773).

Changes:

  • Merge product.sub.json’s embedded section into the existing productObj.embedded instead of overwriting it.
  • Preserve the rest of product.sub.json overrides as before via Object.assign(productObj, productSubObj).

Comment thread src/bootstrap-meta.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Screenshot Changes

Base: eb9cbc56 Current: 645c49ce

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@deepak1556 deepak1556 merged commit 334c5b7 into main Apr 20, 2026
30 checks passed
@deepak1556 deepak1556 deleted the roob/fix_sibling_app_spawn branch April 20, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lszomoru lszomoru lszomoru approved these changes

Assignees

@deepak1556 deepak1556

Labels

None yet

Projects

None yet

Milestone

1.117.0

Development

Successfully merging this pull request may close these issues.

3 participants

@deepak1556 @lszomoru