Skip to content

Add 365 regression tests for untested bug fixes#15615

Merged
nohwnd merged 4 commits intomicrosoft:mainfrom
nohwnd:add-missing-tests
Mar 30, 2026
Merged

Add 365 regression tests for untested bug fixes#15615
nohwnd merged 4 commits intomicrosoft:mainfrom
nohwnd:add-missing-tests

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Mar 30, 2026

Summary

Adds regression tests for bug fixes that were merged without test coverage, identified by auditing 61 PRs.

365 tests across 32 files covering:

  • Serialization edge cases (TestCase, TestResult, TestProperty)
  • Command line argument parsing
  • RunSettings XML handling
  • Filter expression parsing
  • TRX logger formatting
  • Blame data collector scenarios
  • Process helper edge cases
  • Console logger timing
  • Discovery/execution flow edge cases

Methodology

Audited merged PRs that fixed bugs but didn't include tests. For each fix, wrote a test that would have failed before the fix and passes after.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Youssef1313 and others added 4 commits March 24, 2026 16:03
Add 32 new test files covering 30 areas of bug fixes that were merged
without corresponding tests. Each test documents which PR/issue it
prevents from regressing.

Areas covered:
- TestProperty.Equals ID-based equality (microsoft#15370)
- TraitCollection.GetTraits with EqualityComparer (microsoft#15370, microsoft#15249)
- CommandLineUtilities backslash-quote parsing (microsoft#15304)
- ManagedNameParser F# method name unescaping (microsoft#4972)
- ManagedNameParser edge cases (microsoft#15259, microsoft#15255)
- Condition evaluation operations refactor (microsoft#15357)
- Condition parsing and tokenization (microsoft#15357)
- TrackableEvent subscribe/notify/wait (microsoft#4553)
- PathConverter path replacement for UWP (microsoft#3367)
- NullPathConverter singleton pattern (microsoft#3367)
- PathConverter attachment handling (microsoft#3367)
- PathConverter DiscoveryCriteria/TestRunCriteria (microsoft#3367)
- DiscoveryDataAggregator source status tracking (microsoft#3381)
- DiscoveryCompleteEventArgs status properties (microsoft#3381)
- DiscoveryCriteria constructor behavior (microsoft#3381)
- JsonDataSerializer discovery status (microsoft#3381)
- JsonDataSerializer payload serialization (microsoft#3381)
- LengthPrefixCommunicationChannel TrackableEvent (microsoft#4553)
- TrxLogger WarnOnFileOverwrite parameter (microsoft#5141)
- VSTestTask2 message parsing and error codes (microsoft#5115, microsoft#5113)
- VSTestTask2 ANSI escape handling (microsoft#5084)
- VSTestTask2 duration formatting (microsoft#4894)
- TestHostManagerCallbacks error as informational (microsoft#5192)
- ConsoleLogger MinimalTestResult timing fix (microsoft#5143)
- TestResult timing properties (microsoft#5143, microsoft#4894)
- TestCase serialization with traits (microsoft#15370)
- TestObject property storage (microsoft#15370, microsoft#15249)
- Condition ValidForProperties (microsoft#15357)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts:
#	src/Microsoft.TestPlatform.Common/ExtensionDecorators/SerialTestRunDecorator.cs
#	src/Microsoft.TestPlatform.Common/ExtensionDecorators/SerialTestRunDecoratorFrameworkHandle.cs
#	src/Microsoft.TestPlatform.CrossPlatEngine/Adapter/FrameworkHandle.cs
#	src/Microsoft.TestPlatform.ObjectModel/Adapter/Interfaces/IFrameworkHandle.cs
Copilot AI review requested due to automatic review settings March 30, 2026 09:42
@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Mar 30, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd added the 🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it". label Mar 30, 2026
@nohwnd nohwnd marked this pull request as ready for review March 30, 2026 13:44
@nohwnd nohwnd requested a review from Evangelink as a code owner March 30, 2026 13:44
@nohwnd nohwnd merged commit 2dfa64d into microsoft:main Mar 30, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants