Skip to content

Comments

Avoid using Write-Host and other Script-Analyzer warnings#180

Merged
AmelBawa-msft merged 9 commits intomicrosoft:mainfrom
Trenly:ScriptAnalyzer
Jan 9, 2026
Merged

Avoid using Write-Host and other Script-Analyzer warnings#180
AmelBawa-msft merged 9 commits intomicrosoft:mainfrom
Trenly:ScriptAnalyzer

Conversation

@Trenly
Copy link
Contributor

@Trenly Trenly commented Nov 19, 2025

📖 Description

This PR

  1. Fixes all of the warnings that Invoke-ScriptAnalyzer was giving
  2. Lints the scripts
  3. Adds a workflow to report any errors for future script updates

🔗 References and Related Issues

🔍 How to Test

  • See first link in related issues for the workflow status
  • Run a test build locally using the updated scripts

✅ Checklist

  • Closes #xxx
  • Tests added/passed
    • Adding the workflow is the test to ensure the files don't have any errors added. Right now there are also no warnings. I opted to not fail the workflow on warnings, but it would be a simple change if we want to keep these scripts exceptionally clean.
  • Documentation updated

@github-actions

This comment has been minimized.

@Trenly Trenly changed the title Avoid using Write-Host Avoid using Write-Host and other Script-Analyzer warnings Nov 19, 2025
@denelon
Copy link
Collaborator

denelon commented Dec 19, 2025

It looks like this needs to be rebased. When @AmelBawa-msft is back, I'll ask him to take a look at this.

@Trenly
Copy link
Contributor Author

Trenly commented Dec 23, 2025

It looks like this needs to be rebased. When @AmelBawa-msft is back, I'll ask him to take a look at this.

I've rebased and updated the implementation

@AmelBawa-msft AmelBawa-msft merged commit 53b80e9 into microsoft:main Jan 9, 2026
3 checks passed
@Trenly Trenly deleted the ScriptAnalyzer branch January 9, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants