Skip to content

Comments

Update UI for validation page and support tabbing#192

Merged
AmelBawa-msft merged 18 commits intomainfrom
user/amelbawa/validation-page-update
Dec 4, 2025
Merged

Update UI for validation page and support tabbing#192
AmelBawa-msft merged 18 commits intomainfrom
user/amelbawa/validation-page-update

Conversation

@AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Nov 27, 2025

📖 Description

  • Moved code from PreviewFileViewModel to PreviewSetViewModel
  • Display error messages as an output tab for Get, Set and Test operatinos
  • Added support for tabs in the validation page
  • Other code enhancements

🎨 Update validation page

Before After
image image
✅ Can cancel Get, Set and Test operations
✅ Validate multiple units in separate tabs
✅ Can update original source unit
✅ Display error messages in each tab
👇 Details below...

🏷️ Tabbing

✅ Validate multiple units in separate tabs
image

❌ Errors

image

✨ Output

image

Validate from configuration file

image

✅ Allow updating the source unit
✅ Allow returning back to the source set

🔗 References and Related Issues

🔍 How to Test

✅ Checklist

@AmelBawa-msft AmelBawa-msft changed the title [Do not review] Update UI for validation page and support tabbing Update UI for validation page and support tabbing Dec 4, 2025
@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review December 4, 2025 22:23
Copy link
Member

@dkbennett dkbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general suggestion to swap null checks to use "is null" and "is not null" for general readability and consistency, and protection against unexpected class behavior if the equals operator happens to be overloaded.

@AmelBawa-msft AmelBawa-msft merged commit fb6f785 into main Dec 4, 2025
8 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/validation-page-update branch December 4, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance code inside preview file view model Linkage between resource playground and manage configuration file

2 participants