remove reference to Preferences of deleting category#1734
remove reference to Preferences of deleting category#1734AntsyLich merged 6 commits intomihonapp:mainfrom
Conversation
AntsyLich
left a comment
There was a problem hiding this comment.
Inject in the class constructor also add a migration to clean existing preferences? And changelog.
A migration seems overkill. These preferences can be easily fixed once user notices and re-set them again. |
Never rely on user action to fix incorrect state. |
Overestimating much? :risitas: |
|
because this referred settings issue been there since long but users didn't really have problem with it that much, meaning this issue is not a critical one. |
How does it prevent uninstalling and installing an old version? It doesn't. And going back to older versions isn't a supported thing for Mihon either. We make it a point in support requests and issues here to make sure people use the latest version before raising complaints. |
it prevents install over (to keep data/cache). Anw, it's opinion because I only said overkill, given the minor affect of this issue comparing to bumping versionCode. |
|
You do realize I'm going bump the version on new release anyway? |
as a matter of fact, no I don't, because there are so little updates so I honestly couldn't notice. anw I'm doing migration now. |
Oi that's a foul :angy: |
AntsyLich
left a comment
There was a problem hiding this comment.
Also bump app version to 10
When a category is deleted, preferences which are referencing to that category should also be clear to avoid null/incorrect settings