Add back explicit update(track) call to Bangumi#1771
Merged
AntsyLich merged 1 commit intomihonapp:mainfrom Feb 25, 2025
Merged
Conversation
Most if not all other trackers do this too. Technically this causes some request duplication (since things like the BaseTracker's setRemoteLastChapterRead fire anyway due to the tracker sheet being open. But considering the reduced number of requests in other places, I think this is still acceptable. This change will allow mihonapp#1736 to proceed, hopefully.
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Feb 25, 2025
Most if not all other trackers do this too. Technically this causes some request duplication (since things like the BaseTracker's setRemoteLastChapterRead fire anyway due to the tracker sheet being open. But considering the reduced number of requests in other places, I think this is still acceptable. This change will allow mihonapp/mihon#1736 to proceed, hopefully. (cherry picked from commit 277d8ba)
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Feb 26, 2025
Most if not all other trackers do this too. Technically this causes some request duplication (since things like the BaseTracker's setRemoteLastChapterRead fire anyway due to the tracker sheet being open. But considering the reduced number of requests in other places, I think this is still acceptable. This change will allow mihonapp/mihon#1736 to proceed, hopefully. (cherry picked from commit 277d8ba)
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Feb 26, 2025
Most if not all other trackers do this too. Technically this causes some request duplication (since things like the BaseTracker's setRemoteLastChapterRead fire anyway due to the tracker sheet being open. But considering the reduced number of requests in other places, I think this is still acceptable. This change will allow mihonapp/mihon#1736 to proceed, hopefully. (cherry picked from commit 277d8ba)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most if not all other trackers do this too. Technically this causes some request duplication (since things like the BaseTracker's setRemoteLastChapterRead fire anyway due to the tracker sheet being open). But considering the reduced number of requests in other places, I think this is still acceptable.
Forgot to say why:
This makes sure that we update Bangumi with our new local data where applicable (like private tracking state).
This change will allow #1736 to proceed, hopefully.
What have we learned from this? Actually think about code. Also, don't hide request stuff in base classes but that's not actionable here.