Artist and author in track search info for anilist#1810
Artist and author in track search info for anilist#1810AntsyLich merged 10 commits intomihonapp:mainfrom
Conversation
|
Oh god that inconsistent gap is gonna annoy the living crap out of me |
|
yeah... it's not great. Any ideas? Tbh we could probably discard score on this screen? It's not really relevant when searching for a track to bind |
Score can be helpful to decide between different versions of the same manga, like when a tracker lists every volume separately as well as the main series, or when they list the pre-serialisation version separately from the serialised one. |
|
don't really get how score helps with that but if you say so, shrink the text a little maybe? |
|
Considering the space issues, maybe we can stick with just the author here? Also, please don't tell me AL returns full ISO 8601 timstamps for the dates. |
I think it's very strange to keep score but remove artist but if that's what the people want lmao
Nah that's just the preview values we have. the actual ones are like YYYY-MM-DD |
Not wrong I guess. I'm not sure myself what the best option would be here.
😅 |
Redesign the composable, I believe in you two |
|
huh, this is actually already a thing without the new items. I guess it's just rare to have all the data? but now with everything lmaooo |
No yeah your right, I just checked in the app not every manga has all the details but the ones that do still push the description down (and its not even that uncommon with all these long as isekai titles making it so that the name stretched lines) but I guess with 2 more that's gonna be a lot more common sight |
|
another option? list all creators just under the title?
tho we might wanna just think about redesigning this anyway cus that overflow, pushing down the desc is still possible regardless |
|
If people are happy with that little add we can probably end this here and open someething else to think about redesigning it if that is desired. |
NarwhalHorns
force-pushed
the
artist-in-track-search-info
branch
from
73a3ab0 to
7e9e94c
Compare
…eviewProvider.kt Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
…/mihon#1810) Co-authored-by: Cuong-Tran <cuongtran.tm@gmail.com> Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> (cherry picked from commit b702603)
4 participants
Include the artist and author information from anilist in the tracker search if available.
If all artists are the same as all authors it doesn't display artists.
Only thing i'm maybe concious of is that if ALL the info is there then it runs quite long and pushed the description quite low. Thought about putting the artist/authors on one row but don't think we have the space really.
But I think it's worth having this info on there.
I've put in a good amount of null protection cus I just don't know if those values are guaranteed from anilist query