Migrate to new AGP Plugin | Add support for new AGP Plugin#1283
Migrate to new AGP Plugin | Add support for new AGP Plugin#1283
Conversation
mikepenz
commented
Dec 21, 2025
mikepenz
commented
- Migrate the project to the new Android Gradle plugin replacing the old plugin
- Migrate to the new advised project structure for sample app
- Upgrade gradle plugin to support the new AndroidComponentExtension of the new AGP plugin
- FIX Incompatiable with AGP 9 #1265
- add full theme switch to the sample app for v2/v3 material, light and dark mode
…old plugin Migrate to the new advised project structure for sample app
…of the new AGP plugin - FIX #1265
There was a problem hiding this comment.
Pull request overview
This PR migrates the AboutLibraries project to the new Android Gradle Plugin (AGP) and restructures the sample application into a multiplatform setup with separate modules for different platforms. The changes also introduce theme switching capabilities between Material Design 2 and Material Design 3, along with light/dark mode support.
Key Changes:
- Restructured sample app into platform-specific modules (shared, android, desktop, web, iOS)
- Upgraded version catalog from 0.10.4 to 0.11.2
- Implemented full theme switching (M2/M3, light/dark modes) in the sample app
Reviewed changes
Copilot reviewed 92 out of 186 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Updated version catalog and added new sample module includes |
| sample/shared/* | New shared module with common UI code, themes (M2/M3), icons, and sample app implementation |
| sample/web/* | New web module with WASM support and HTML resources |
| sample/desktop/* | New desktop module with JVM main entry point |
| sample/ios/* | iOS app configuration with Swift UI integration |
| sample/android/* | Android-specific configuration (gradle.properties) |
| sample/*/build.gradle.kts | Build configuration for each platform module |
Files not reviewed (1)
- iosApp/iosApp.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,112 @@ | |||
| package com.mikepenz.markdown.sample.icon | |||
There was a problem hiding this comment.
Package name mismatch: The package is declared as com.mikepenz.markdown.sample.icon but should be com.mikepenz.aboutlibraries.sample.icon to match the file path and maintain consistency across the icon files.
| @@ -0,0 +1,14 @@ | |||
| package com.mikepenz.markdown | |||
There was a problem hiding this comment.
Package name mismatch: The package is declared as com.mikepenz.markdown but should be com.mikepenz.aboutlibraries to match the actual directory structure and the rest of the codebase. This will cause import errors when trying to use MainViewController.
| @@ -0,0 +1,74 @@ | |||
| package com.mikepenz.markdown.sample.icon | |||
There was a problem hiding this comment.
Package name mismatch: The package is declared as com.mikepenz.markdown.sample.icon but should be com.mikepenz.aboutlibraries.sample.icon to match the file path and other files in the project. This inconsistency could cause confusion and import issues.
| @@ -0,0 +1,69 @@ | |||
| package com.mikepenz.markdown.sample.icon | |||
There was a problem hiding this comment.
Package name mismatch: The package is declared as com.mikepenz.markdown.sample.icon but should be com.mikepenz.aboutlibraries.sample.icon to match the file path and maintain consistency with the project structure.
Generated by 🚫 Danger |
make the settings bottom sheet also flip with theme make ios sample fullscreen
Currently blocked on mikepenz/AboutLibraries#1283 being released
Currently blocked on mikepenz/AboutLibraries#1283 being released
|
I can't see any mention of SNAPSHOT builds in the README, do you publish artifacts from the develop branch that I can use to test this in my own project? |
|
@msfjarvis unfortunately no SNAPSHOT builds, but I plan to have an alpha sometimes soon. |
|
@msfjarvis There's a first version of this in 14.0.0-a01 |
Currently blocked on mikepenz/AboutLibraries#1283 being released
