Prepare for paparazzi screenshot tests#1285
Merged
Conversation
upgrade convention plugin with setup for screenshot testing cleanup some code, simplify configurations
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the codebase for screenshot testing with Paparazzi by reorganizing test code and updating dependencies. The changes focus on moving screenshot test files to a dedicated package structure and configuring the Paparazzi plugin for automated screenshot testing using ComposablePreviewScanner.
- Updated version catalog and multiple dependencies to their latest versions
- Reorganized screenshot test files into a dedicated
com.mikepenz.aboutlibraries.screenshotpackage structure with M2 and M3 subpackages - Configured Paparazzi plugin with ComposablePreviewScanner for automated preview-based screenshot testing
Reviewed changes
Copilot reviewed 9 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Bumped version catalog from 0.11.2 to 0.11.3 |
| sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt | Relocated from old package, updated imports and refactored preview composables to use LibrariesContainer |
| sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt | Relocated from old package, updated imports and refactored preview composables to use LibrariesContainer |
| sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/LibraryScaffoldPreviews.kt | Relocated to screenshot package with updated imports |
| sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/FakeData.kt | Relocated to screenshot package to be shared across test files |
| sample/android/build.gradle.kts | Added Paparazzi plugin, M2/M3 compose dependencies, and configured composablePreviewPaparazzi settings |
| gradle/libs.versions.toml | Updated multiple dependency versions (activity, lifecycle, navigation, iconics, modelBuilder, okhttp) |
| build.gradle.kts | Applied Paparazzi plugin to project |
| aboutlibraries-compose/build.gradle.kts | Removed unused import and applyDefaultHierarchyTemplate call |
| aboutlibraries-compose-m3/src/screenshotTest/kotlin/com/mikepenz/aboutlibraries/ui/compose/m3/data/FakeData.kt | Deleted file (moved to shared location) |
| aboutlibraries-compose-m3/src/debug/screenshotTest/reference/*.png | Deleted old screenshot reference files from previous test location |
| aboutlibraries-compose-m2/src/debug/screenshotTest/reference/*.png | Deleted old screenshot reference files from previous test location |
Comments suppressed due to low confidence (4)
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt:31
- Inconsistent parameter naming style. This line uses named parameter 'libraries' but the call on line 40 in PreviewLibraryRTL uses positional parameter. Consider using named parameter consistently for clarity, especially since 'libraries' is the first parameter and could be confused with other parameters.
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt:40 - Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the calls on lines 23 and 31 use named parameter 'libraries'. Consider using named parameter consistently for clarity.
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt:31 - Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the call on line 23 uses named parameter 'libraries'. Consider using named parameter consistently for clarity.
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt:40 - Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the calls on lines 23 and 31 use named parameter 'libraries'. Consider using named parameter consistently for clarity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently blocked by a paparazzi release which supports the new AGP.
Prepare for screenshot tests using paparazzi and https://github.com/sergio-sastre/ComposablePreviewScanner