Skip to content

Prepare for paparazzi screenshot tests#1285

Merged
mikepenz merged 4 commits intodevelopfrom
feature/screenshot_tests
Dec 27, 2025
Merged

Prepare for paparazzi screenshot tests#1285
mikepenz merged 4 commits intodevelopfrom
feature/screenshot_tests

Conversation

@mikepenz
Copy link
Owner

This is currently blocked by a paparazzi release which supports the new AGP.

Prepare for screenshot tests using paparazzi and https://github.com/sergio-sastre/ComposablePreviewScanner

Copilot AI review requested due to automatic review settings December 27, 2025 10:52
@mikepenz mikepenz added the other label Dec 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the codebase for screenshot testing with Paparazzi by reorganizing test code and updating dependencies. The changes focus on moving screenshot test files to a dedicated package structure and configuring the Paparazzi plugin for automated screenshot testing using ComposablePreviewScanner.

  • Updated version catalog and multiple dependencies to their latest versions
  • Reorganized screenshot test files into a dedicated com.mikepenz.aboutlibraries.screenshot package structure with M2 and M3 subpackages
  • Configured Paparazzi plugin with ComposablePreviewScanner for automated preview-based screenshot testing

Reviewed changes

Copilot reviewed 9 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
settings.gradle.kts Bumped version catalog from 0.11.2 to 0.11.3
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt Relocated from old package, updated imports and refactored preview composables to use LibrariesContainer
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt Relocated from old package, updated imports and refactored preview composables to use LibrariesContainer
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/LibraryScaffoldPreviews.kt Relocated to screenshot package with updated imports
sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/FakeData.kt Relocated to screenshot package to be shared across test files
sample/android/build.gradle.kts Added Paparazzi plugin, M2/M3 compose dependencies, and configured composablePreviewPaparazzi settings
gradle/libs.versions.toml Updated multiple dependency versions (activity, lifecycle, navigation, iconics, modelBuilder, okhttp)
build.gradle.kts Applied Paparazzi plugin to project
aboutlibraries-compose/build.gradle.kts Removed unused import and applyDefaultHierarchyTemplate call
aboutlibraries-compose-m3/src/screenshotTest/kotlin/com/mikepenz/aboutlibraries/ui/compose/m3/data/FakeData.kt Deleted file (moved to shared location)
aboutlibraries-compose-m3/src/debug/screenshotTest/reference/*.png Deleted old screenshot reference files from previous test location
aboutlibraries-compose-m2/src/debug/screenshotTest/reference/*.png Deleted old screenshot reference files from previous test location
Comments suppressed due to low confidence (4)

sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt:31

  • Inconsistent parameter naming style. This line uses named parameter 'libraries' but the call on line 40 in PreviewLibraryRTL uses positional parameter. Consider using named parameter consistently for clarity, especially since 'libraries' is the first parameter and could be confused with other parameters.
    sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m3/M3SnapshotTests.kt:40
  • Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the calls on lines 23 and 31 use named parameter 'libraries'. Consider using named parameter consistently for clarity.
    sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt:31
  • Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the call on line 23 uses named parameter 'libraries'. Consider using named parameter consistently for clarity.
    sample/android/src/main/kotlin/com/mikepenz/aboutlibraries/screenshot/m2/M2SnapshotTests.kt:40
  • Inconsistent parameter naming style. This line uses positional parameter for 'fakeData' but the calls on lines 23 and 31 use named parameter 'libraries'. Consider using named parameter consistently for clarity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mikepenz mikepenz merged commit 48a1967 into develop Dec 27, 2025
3 checks passed
@mikepenz mikepenz deleted the feature/screenshot_tests branch December 27, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants