Open
Conversation
Tox is running (and failing) both 2.7 and 3.9 now
Owner
|
@alanjds Thank for submitting this PR, I think Python 3.X support would be a wonderful thing to add! GenePeeks used to be a company I worked for, but the API is sadly no longer around... So I would add some mocking around the API or using something like As for supporting Python 2.7, I'd definitely like to do it, if for nothing else than just on principal (I'm sure some people will be using it 10 years from now still). This is a small library so I imagine it won't be a huge overhead in the maintenance. I will take a pass on the tests and get back to you with some insights on where we should go from here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First shot for Python 3 support: pass 2to3 on the codebase.
Resulted in an importable and working(?) module. Tests fail on name resolution over api.genepeeks.com and I guess this is not a fault of the module. The changes also broke Py2.7. May be possible to have it work by using
futuresmodule as a compatibility layer. Idk if is worth, as Py2.7 is EOLed for almost an year already.That said, I have no way to know if this is working. My target REST API is Django Rest Framework, that does not honor .filter() without plugins.
Owner/maintainer, please enlighten the next steps needed here.
(and thanks for the existing code)