Skip to content

Conversation

@xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 12, 2022

fix issue: #15139
/kind bug
Signed-off-by: xige-16 [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 12, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 12, 2022
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2022

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #15181 (fad0438) into master (2528b68) will decrease coverage by 0.00%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15181      +/-   ##
==========================================
- Coverage   80.15%   80.14%   -0.01%     
==========================================
  Files         445      445              
  Lines       60789    60816      +27     
==========================================
+ Hits        48723    48744      +21     
- Misses       9765     9767       +2     
- Partials     2301     2305       +4     
Impacted Files Coverage Δ
internal/querycoord/index_checker.go 72.28% <60.60%> (-1.23%) ⬇️
internal/datacoord/services.go 86.28% <100.00%> (-0.06%) ⬇️
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-7.30%) ⬇️
internal/rootcoord/proxy_manager.go 63.23% <0.00%> (-2.95%) ⬇️
internal/util/sessionutil/session_util.go 76.97% <0.00%> (-1.38%) ⬇️
internal/datacoord/segment_manager.go 81.78% <0.00%> (-1.04%) ⬇️
internal/querynode/query_node.go 85.29% <0.00%> (-0.74%) ⬇️
internal/indexcoord/meta_table.go 83.11% <0.00%> (-0.26%) ⬇️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (ø)
internal/indexcoord/index_coord.go 79.37% <0.00%> (+0.29%) ⬆️
... and 7 more

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Jan 13, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2022

@xige-16 E2e jenkins job failed, comment /run-checks can trigger the job again.

@sre-ci-robot sre-ci-robot merged commit cc5bee4 into milvus-io:master Jan 13, 2022
@xige-16 xige-16 deleted the handoff-compact branch July 14, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants