Skip to content

Conversation

@bigsheeper
Copy link
Contributor

Signed-off-by: bigsheeper [email protected]

issues: #15193

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 14, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #15221 (af05e30) into master (408a6e9) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15221      +/-   ##
==========================================
- Coverage   79.70%   79.66%   -0.04%     
==========================================
  Files         450      450              
  Lines       61426    61431       +5     
==========================================
- Hits        48960    48942      -18     
- Misses      10122    10143      +21     
- Partials     2344     2346       +2     
Impacted Files Coverage Δ
internal/util/mqclient/pulsar_consumer.go 91.66% <71.42%> (-2.37%) ⬇️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 77.31% <0.00%> (-2.53%) ⬇️
internal/distributed/querycoord/client/client.go 69.94% <0.00%> (-2.19%) ⬇️
internal/indexnode/indexnode_mock.go 84.84% <0.00%> (-1.90%) ⬇️
internal/datacoord/segment_manager.go 81.09% <0.00%> (-1.72%) ⬇️
internal/querynode/query_collection.go 81.39% <0.00%> (-0.43%) ⬇️
internal/indexcoord/meta_table.go 83.02% <0.00%> (-0.27%) ⬇️
internal/indexcoord/index_coord.go 79.37% <0.00%> (+0.29%) ⬆️

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Jan 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2022

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Copy link
Contributor

xige-16 commented Jan 16, 2022

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2022

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7f77509 into milvus-io:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants