Base implementation of catching exceptions made in C stubs#433
Open
SturdyPose wants to merge 15 commits intomirage:mainfrom
Open
Base implementation of catching exceptions made in C stubs#433SturdyPose wants to merge 15 commits intomirage:mainfrom
SturdyPose wants to merge 15 commits intomirage:mainfrom
Conversation
MisterDA
approved these changes
Mar 5, 2026
Collaborator
MisterDA
left a comment
There was a problem hiding this comment.
There's a bit of mixed indentation in the C file, please reformat the Windows code to be consistent with the rest.
Author
|
Applied clang-format on source |
Author
|
Seems like windows containers are broken because they don't have npm and I'm unsure why mac is not catching the exception... 🤔 |
MisterDA
reviewed
Mar 12, 2026
MisterDA
requested changes
Mar 12, 2026
Author
|
Yeah, I'll need to rethink the implementation of reporting it back to ocaml -> might not be possible at all. There can be stack corruption and that would lead to undeterministic results. Do you think that reporting it to stderr would be good enough? |
Collaborator
|
For the unix part maybe you need a signal handler on the ocaml side instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix #430
Open to any feedback. :)