Adapt to mirage/repr#81 (improved binary decoder type)#1547
Merged
craigfe merged 3 commits intomirage:mainfrom Nov 16, 2021
Merged
Adapt to mirage/repr#81 (improved binary decoder type)#1547craigfe merged 3 commits intomirage:mainfrom
craigfe merged 3 commits intomirage:mainfrom
Conversation
7c6f110 to
7ad11f2
Compare
Ngoguey42
reviewed
Oct 12, 2021
7ad11f2 to
c099331
Compare
Ngoguey42
reviewed
Oct 12, 2021
acbfd9d to
d25c6bf
Compare
Contributor
|
The benchmarks fail with this error: :) |
Member
Author
|
Thanks @gs0510. I hope that will be fixed by updating the Index pin to include mirage/index#358, which I've now done. |
Member
Author
|
Both CI and CB now passing 🎉 (ish – we still have that problem with Odoc) |
Ngoguey42
approved these changes
Oct 15, 2021
e05c991 to
1e2d4de
Compare
Member
Author
|
Rebased now that the CB is working again. I'm interested to know what the impact of this is now that #1577 has been merged. |
Member
Author
|
The numbers suggest this gives another 6.6% reduction in minor bytes allocated (and number of minor collections). I'm in favour of merging mirage/repr#81 and the corresponding PRs in |
Member
Author
|
I'm planning to merge this today. |
b45bb61 to
a344e1f
Compare
Needed to pull an Index version that is compatible with the latest Repr.
68039d4 to
a845ca8
Compare
Member
Author
|
Thanks both for the reviews. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mirage/repr#81.