Conversation
dinosaure
force-pushed
the
fix-config-about-cross
branch
2 times, most recently
from
af86076 to
6e60682
Compare
…et value according to how we want to compile with solo5
dinosaure
force-pushed
the
fix-config-about-cross
branch
from
6e60682 to
8122f10
Compare
Member
|
Looks fine to me. Should we eventually disable the "ocaml-ci" in this repository, since it doesn't work anyways? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by
bobandesperanto, we currently don't really specify the right target (at least, the architecture of it) which is needed by some packages likeocaml-gmpto be able to cross-compile artifacts to the right assembler. This patch want to clarify that and allows us to really cross-compile a project toaarch64. It was not spotted because we never tried to useocaml-solo5as a real cross-compiler foraarch64for larger projects.