Skip to content

Fix index.d.ts by adding missing typings#996

Open
rugk wants to merge 1 commit intomissive:mainfrom
rugk:patch-5
Open

Fix index.d.ts by adding missing typings#996
rugk wants to merge 1 commit intomissive:mainfrom
rugk:patch-5

Conversation

@rugk
Copy link
Copy Markdown

@rugk rugk commented May 12, 2025

  • shortcodes was missing from the skins
  • I also found search

Both found by analyzing the response from SearchIndex.search. Maybe this method however just adds/modifies the types?

Ref #576

* `shortcodes` was missing from the skins
* I also found `search` 

Both found by analyzing the response from `SearchIndex.search`. Maybe this method however just adds/modifies the types?
@rugk rugk changed the title Fix index.d.ts Fix index.d.ts by adding missing typings May 12, 2025
rugk added a commit to rugk/awesome-emoji-picker that referenced this pull request May 12, 2025
rugk added a commit to rugk/awesome-emoji-picker that referenced this pull request May 12, 2025
@rugk
Copy link
Copy Markdown
Author

rugk commented May 12, 2025

Apparently, the shortcode is just the ID of the emoji set with added colons (:) so (and optionally appended by the skin modifier):

skin.shortcodes = `:${emoji.id}:${skinShortcodes}`

@SvenBudak
Copy link
Copy Markdown

Any news on this? i really hope for a merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants