Ability to filter available testsets by language pair#211
Merged
mjpost merged 9 commits intomjpost:masterfrom Oct 4, 2022
Merged
Ability to filter available testsets by language pair#211mjpost merged 9 commits intomjpost:masterfrom
mjpost merged 9 commits intomjpost:masterfrom
Conversation
Using ``` sacrebleu --list -l en-fr ``` test sets available in English-French are listed.
Contributor
Author
|
Please let me know if something with codestyle or style of implementation is wrong and I will change it. Hope it is useful! |
Contributor
Author
|
I thought |
Owner
|
Thanks! Can you give me write permission to your branch, so I add a few small changes (e.g., I updated the CHANGELOG). |
Owner
|
@ZJaume Let me know if you can give me write access. If so, I'll push up a few changes and merge. If not, I'll have to create a local branch and have someone else approve it. |
Contributor
Author
|
There you go! I gave you collaborator access to my fork. |
Owner
|
Thanks very much! I'll release this with 2.2.2 soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #210
Using
test sets available in English-French are listed.
tests are passing.
Some examples:
Swapping the language pair gives the same output for consistence with download, that is able to find the set regardless of direction I guess.