Display scoring plays like Gameday#77
Merged
andschneider merged 3 commits intomlb-rs:mainfrom Jul 3, 2025
Merged
Conversation
andschneider
reviewed
Jul 3, 2025
Collaborator
andschneider
left a comment
andschneider
left a comment
There was a problem hiding this comment.
thanks for the PR! definitely ok with this change, I think it's a lot more clear with the team abbreviations there.
just a tiny comment about the tuple args and an idea about using brackets instead of parentheses (up to you on that one)
Contributor
Author
|
Updated! |
andschneider
approved these changes
Jul 3, 2025
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like how the Gameday website shows the score at the end of each scoring play, along with the team abbreviations:
Again, please feel free to close this PR if you prefer the existing look; I'm happy to maintain a personal fork. I know it can be weird when others randomly show up on your personal project! Also happy to revise the code according to any stylistic preferences, or make this an option in the settings file.