Add a League view to the Standings page.#87
Merged
andschneider merged 6 commits intomlb-rs:mainfrom Jul 29, 2025
Merged
Conversation
Contributor
Author
|
I can't seem to add reviewers? |
Collaborator
andschneider
left a comment
andschneider
left a comment
There was a problem hiding this comment.
This is sweet, thanks!
A couple of implementation comments and a couple of stylistic comments, but overall looks good!
Contributor
Author
|
Corrected the formatting issues. Let me take a look at your comments. |
…ng league_standings to the state.
andschneider
approved these changes
Jul 29, 2025
Collaborator
andschneider
left a comment
andschneider
left a comment
There was a problem hiding this comment.
Looks good. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've always preferred viewing the league standing in total rather than per division.
I've added that view to standings, simply flip back and forth between the "Division View" and the "League" view.