Merged
Conversation
Collaborator
andschneider
commented
Feb 27, 2026
andschneider
commented
- Seems like the API response changed for previous year standings so the team names weren't working. This hydrates the response with the full team model to fix it.
- Also makes division data optional in the API so that pre-1969 standings now parses correctly. In the UI if there is no division data it falls back to the league. This closes issue Standings view breaks pre 1969 season #57
The API response started returning teams' short name, instead of the full name. This was breaking the name lookup. Hydrating the team in the API returns the full name again.
Make the division data in the API optional and then fallback to league for sorting the standings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.