Skip to content

Fix #159 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cregouby merged 4 commits into from
Jul 29, 2024
Merged

Fix #159 #160

cregouby merged 4 commits into from
Jul 29, 2024

Conversation

@cphaarmeyer
Copy link
Contributor

@cphaarmeyer cphaarmeyer commented Jul 26, 2024

Fix #159

@cregouby
Copy link
Collaborator

cregouby commented Jul 27, 2024

Hello @cphaarmeyer

Thanks a lot for this contribution !
Would you mind adding yourself to the package DESCRIPTION file in the person list as contributor("ctb")?

cregouby added 3 commits July 27, 2024 12:07
@cregouby
add fix to NEWS
6ae7160
@cregouby
properly manage dials parameters in parsnip,
9732d02 
rename 2 `tabnet()` params to `rate_decay` and `rate_step_size`
add tests for that
@cregouby
fix R CMD check
5a9cb18
@cphaarmeyer
Copy link
Contributor Author

cphaarmeyer commented Jul 29, 2024

Hello @cregouby, my name is actually already there :)

@cregouby cregouby merged commit c8c82d2 into mlverse:main Jul 29, 2024
@cphaarmeyer cphaarmeyer deleted the namespace-dials branch July 29, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: "'xxx' is not an exported object from 'namespace:dials'" when trying to tune the hyperparameters of TabNet

2 participants

@cphaarmeyer @cregouby