Skip to content

Conversation

@cregouby
Copy link
Collaborator

@cregouby cregouby commented Feb 8, 2021

Hello,
Unsupervised training is working now, and can be part of training scenario ( see test-hardhat-scenarios.R)
except for CUDA where I can't get torch_bernoulli() work on GPU (see mlverse/torch#480)
Fix #18

dead-end as function design is not ready
fix typo in epoch_shift
add random_obfuscator()
fix unsupervised_loss()
fix y has one column in tabnet_train_unsupervised()
lower data size in secondary tests
fix typo in subseting dataset in test
add train_batch_un() and valid_batch_un()
fix epoch_shift value missing
@cregouby cregouby marked this pull request as draft February 8, 2021 08:02
Christophe-Regouby and others added 2 commits February 8, 2021 09:08
Merge branch 'main' of https://github.com/mlverse/tabnet into feature/unsupervised_training

# Conflicts:
#	R/model.R
@dfalbel
Copy link
Member

dfalbel commented Feb 8, 2021

Hey @cregouby ! This looks awesome!! It's almost there!
I have pushed some changes.

I think the problem was that the decoder was returning only the combined steps output instead of the intermediate ones.

We now get to a print("Done") but fails in serialization.
Let me know if this is helpful!

@cregouby
Copy link
Collaborator Author

cregouby commented Feb 8, 2021

Thanks a lot for this push @dfalbel ! I'll definitively continue with the model serialization.

@cregouby cregouby marked this pull request as ready for review February 16, 2021 19:13
Copy link
Member

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @cregouby ! Merging now!

@dfalbel dfalbel merged commit 28a494a into mlverse:main Mar 2, 2021
@cregouby
Copy link
Collaborator Author

cregouby commented Mar 2, 2021

Thanks a lot, @dfalbel !

@cregouby cregouby deleted the feature/unsupervised_training branch March 2, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unsupervised pre-training

3 participants