Skip to content

Add support for missings values in predictors for tabnet_fit() and predict() #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cregouby merged 8 commits into from
Dec 30, 2021
Merged

Add support for missings values in predictors for tabnet_fit() and predict() #76

cregouby merged 8 commits into from
Dec 30, 2021

Conversation

@cregouby
Copy link
Collaborator

@cregouby cregouby commented Dec 20, 2021 •
edited
Loading

and thus fix #74

  • move predict() to a coro::loop() and dataloader() to give room to multi worker performance
  • move missing-related test into a dedicated test file

@cregouby cregouby requested a review from dfalbel December 20, 2021 11:23
dfalbel
dfalbel approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cregouby cregouby merged commit ee684b1 into main Dec 30, 2021
@cregouby cregouby deleted the feature/missings_in_fit branch December 30, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfalbel dfalbel dfalbel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for missing features in the supervised tasks (fit and predict)

3 participants

@cregouby @dfalbel