Skip to content

fix: make strict combinator check for missing values#240

Merged
mmkal merged 3 commits intommkal:mainfrom
jpdenford:main
Sep 11, 2021
Merged

fix: make strict combinator check for missing values#240
mmkal merged 3 commits intommkal:mainfrom
jpdenford:main

Conversation

@jpdenford
Copy link
Contributor

Ensure strict combinator fails when required properties are missing from input object.

@jpdenford
Copy link
Contributor Author

Thanks for the great library! 🙏
I presume that the change brings strict more inline with intended behaviour but if not then apologies for my misunderstanding.
I was also unsure of whether this change would just be a patch or something more drastic due to potential downstream breakages so I intentionally left that out.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #240 (c6a776c) into main (43cf60b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines          725       725           
  Branches       121       121           
=========================================
  Hits           725       725           
Impacted Files Coverage Δ
packages/io-ts-extra/src/combinators.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cf60b...c6a776c. Read the comment docs.

@mmkal
Copy link
Owner

mmkal commented Sep 11, 2021

Thank you and sorry for the delay in merging!

@mmkal mmkal changed the title Make strict combinator check for missing values fix: make strict combinator check for missing values Sep 11, 2021
@mmkal mmkal merged commit 355da28 into mmkal:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants