Slightly faster PNG generation, improved Py2 vs Py3 compatibility#47
Open
heuer wants to merge 2 commits intomnooner256:masterfrom
heuer:feature/png-performance
Open
Slightly faster PNG generation, improved Py2 vs Py3 compatibility#47heuer wants to merge 2 commits intomnooner256:masterfrom heuer:feature/png-performance
heuer wants to merge 2 commits intomnooner256:masterfrom
heuer:feature/png-performance
Conversation
Contributor
Author
|
See #49 for more improvements |
4 tasks
heuer
added a commit
to pyqrcode/pyqrcodeNG
that referenced
this pull request
Jun 2, 2018
|
how to install pyqrcode in anaconda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Michael,
Maybe you remember me from some contributions 1,5 years ago... . Since then I developed another QR Code lib (Segno) and ran some benchmarks against popular QR Code generators; cf. https://github.com/heuer/segno/blob/master/sandbox/benchmarks.py or https://segno.readthedocs.io/en/latest/comparison-qrcode-libs.html#create-a-qr-code-and-serialize-it-as-png
PyQRCode's PNG generation is (in comparision to the other libs) slow. I tried to improve the performance a bit. Acc. to my tests, PyQRCode renders the PNG images ca. 40ms faster than before. PyPNG is still a bottleneck, but maybe you find the improvment (use generator instead of a list of lists) worth to merge.
Regards,
Lars