Skip to content

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Jan 18, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Improved broadcast extension startup with enhanced error handling and timeout management.
    • Clarified error messaging for broadcast-related failures.
  • Chores

    • Added graceful server shutdown with signal handling for improved stability.
    • Enhanced logging for broadcast extension initialization and port-forwarding operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors iOS device broadcast button interaction into a dedicated helper method, introduces graceful server shutdown with signal handling, and updates the screencapture handler to accept HTTP request parameters for additional context during request processing.

Changes

Cohort / File(s) Summary
iOS Device Kit Startup
devices/ios.go
Extracts "Start Broadcast" button clicking logic into new clickStartBroadcastButton helper method with timeout handling and polling. Integrates helper into StartDeviceKit flow with enhanced verbose logging around broadcast extension startup. Normalizes error messaging and ensures port forwarder cleanup on failure.
Server Graceful Shutdown & Screencapture Handler
server/server.go
Implements graceful server shutdown via goroutine with OS signal (SIGINT, SIGTERM) handling and 10-second timeout. Updates handleScreenCapture signature to accept *http.Request as first parameter for request-aware processing; propagates change to all call sites.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit cd95803 into main Jan 18, 2026
6 of 7 checks passed
@gmegidish gmegidish deleted the fix-better-support-sigint-while-screencapture branch January 18, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants